New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing keywords to JS and TS #1741
Conversation
And should |
I know, my point is though that from/as are not official keywords, or are they? I'm trying to understand if treating them the same as "import" is correct, given that is reserved. |
https://tc39.es/ecma262/2020/#sec-keywords-and-reserved-words |
Also removed invalid "AS" from TypeScript lexer.
For a more general PR, we could add :
|
Yes, that sounds good, but I'd rather do it in a separate PR. This here is nice and self-contained. Can you please un-draft it so I can merge it, then file another PR for the other changes? |
from
keyword was missing (import something from 'something'
)