-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Futhark lexer #1691
Add Futhark lexer #1691
Conversation
Oh my, perhaps I overdid it by adding so many examples... |
869b85c
to
6b46c36
Compare
Hi, yes, I think that's a bit much on the example side. Could you please try to condense it to 1-2 files at most? Please keep in mind that all code you submit here must be yours or BSD compatible, and I do get nervous when I see large amounts of code getting submitted :) |
Hi @Anteru, thanks for your comment. I have added just a single example, that I've written myself for the occasion. Hopefully, this is more to your liking :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Unfortunately quite a few of the tokens generated by the examplefile are Error
s :)
(The current way examplefiles are handled is pretty new, which is why this wasn't caught by the test. We'll get a fix whipped up for that.)
Ah, yes, I can see that. I didn't know that it needed to classify everything correctly. I'll try to find some time to address this. |
14a9329
to
0f2caf6
Compare
@birkenfeld I've tried to update my lexer a bit, but now I'm getting an error in the linter: overlap in character class. I don't know what that means, perhaps you can help me understand? |
@Munksgaard it means that you have a single character multiple times in a character class. One way to do that is simply something like
The |
Thank you, I've tried that now :) |
Merged, thanks! |
The purpose of this PR is to add support for the Futhark programming language.
I've tried to follow the guide on https://pygments.org/docs/lexerdevelopment/, but please let me know if there's something else I need to do.