-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for lexing Python raw f-strings with backslashes #1683
Conversation
Thanks for preparing the fix! Can you please add an unit test for this as well? |
I've added three tests; one for just "rawness", one for just usual f-string behavior and one for the previously missing combined behavior. |
@Anteru Note that I've rewritten the old (r'\{\{', String.Escape),
(r'\}\}', String.Escape), twice. Is this done correctly? |
Sounds reasonable to me, thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fix for #1681
'rfstringescape'
, used for raw f-strings.'fstringescape'
as a composite of'rfstringescape'
and'stringescape'
.