MATLAB parser cleanup & fix for parsing 1./x
#1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There have been quite a bunch of changes in the Matlab lexer. Could you please take a look and rebase to the latest version? |
Expand a bit the explanation; remove an unnecessary non-capturing group, replace \s+ by \s at the end (we just need to check for the presence of a space).
|
rebased |
Anteru
added
the
changelog-update
|
Perfect, thanks a lot! |
Anteru
removed
the
changelog-update
This was referenced Mar 8, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit: Clarify recognition of "command form" by MATLAB parser.
Expand a bit the explanation; remove an unnecessary non-capturing group,
replace \s+ by \s at the end (we just need to check for the presence of
a space).
2nd commit: MATLAB: Correctly parse 1./x as (1)(./)(x).