Add __END_LINE__ to Crystal syntax highlighting #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found `__END_LINE__` magic constant is missing in syntax highlighting for Crystal language.
|
I want to have review by @oprypin |
oprypin
approved these changes
Jan 8, 2021
Comment on lines
173
to
+174
| previous_def forall out uninitialized __DIR__ __FILE__ __LINE__ | ||
| __END_LINE__ |
There was a problem hiding this comment.
The way that the lines are split looks weird, but this is technically the most correct way, so nothing to do here.
There was a problem hiding this comment.
I'm not familiar with code style of this project, but all lines seem to be limited within 90 characters. If this is put at L173, L173 will exceed 90 chars. Please let me know if my understanding is not correct.
There was a problem hiding this comment.
Our "desired" target line length is 90 characters, so this looks fine. The 90 character rule hasn't been enforced but it's a general guideline.
Anteru
added
the
changelog-update
|
Merged, good catch! |
Anteru
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
__END_LINE__magic constant is missing in syntax highlighting for Crystal language.https://crystal-lang.org/reference/syntax_and_semantics/constants.html