Fix eiffel regex performance #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
approved these changes
Feb 12, 2021
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a certain eiffel file that performed extremely poorly with this regex. (I can share an example if desired, I'm not sure what proper etiquette is).
This change avoids the performance problem, and output is unchanged for the
example.efile and a few other .e files I tested. I am not very experienced with eiffel language syntax, but as far as I can tell this is an okay change to make.