Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexer for graphviz #1657

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Add lexer for graphviz #1657

merged 1 commit into from
Feb 7, 2021

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Dec 30, 2020

Discussion here: #731

Resolves #731

@nikeee nikeee mentioned this pull request Dec 30, 2020
Closed
@Anteru
Copy link
Collaborator

Anteru commented Jan 4, 2021

Thanks for the contribution! Can you please add an example file as well?

@Anteru Anteru added this to the 2.8 milestone Jan 4, 2021
@nikeee
Copy link
Contributor Author

nikeee commented Jan 5, 2021 •
edited

I'll take som inspiration from this PR: https://github.com/pygments/pygments/pull/1519/files (on what this PR should also change).
Seems that there is something missing in other files as well.

@prodigion
Copy link

There's some examples here that you could copy: https://github.com/xflr6/graphviz/tree/master/examples/

@nikeee
Copy link
Contributor Author

nikeee commented Jan 8, 2021

I updated the PR.

Anteru
Anteru requested changes Jan 17, 2021
View reviewed changes
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, only very minor changes needed before we can land this.

doc/languages.rst Outdated Show resolved Hide resolved
pygments/lexers/graphviz.py Outdated Show resolved Hide resolved
pygments/lexers/graphviz.py Outdated Show resolved Hide resolved
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Jan 17, 2021
@nikeee
Copy link
Contributor Author

nikeee commented Jan 17, 2021 •
edited

I pushed an update that addresses the stuff that came up in the review.

@simonwo simonwo mentioned this pull request Feb 1, 2021
Merged
@Anteru Anteru merged commit c0e6fa7 into pygments:master Feb 7, 2021
@Anteru
Copy link
Collaborator

Anteru commented Feb 7, 2021

Merged for the next release, thanks for your contribution!

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Feb 14, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Open
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anteru Anteru Anteru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

new lexer request: dot (graphviz)
3 participants
@nikeee @Anteru @prodigion