Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Crystal lexer #1650

Merged
merged 7 commits into from Jan 4, 2021
Merged

Update Crystal lexer #1650

merged 7 commits into from Jan 4, 2021

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Dec 28, 2020

  • drop all classes from builtins; these aren't normally highlighted - broken here
  • fix percent-strings, drop Ruby-specific arbitrary delimiters - broken here
  • update keywords and builtins - broken here, broken here
  • fix string literals and escape sequences - broken here
  • uppercase identifiers aren't always constants - broken here
  • annotations can be namespaced

(see commit messages themselves for a bit more details)

@oprypin
crystal: drop all classes from builtins; these aren't normally highli…
90f7621 
…ghted

("normally" meaning all other highlighter tools)
@oprypin
crystal: fix percent-strings, drop Ruby-specific arbitrary delimiters
0358490 
It seems that Ruby supports strings such as `%*text*` where `*` can be anything. But Crystal never had anything like that. It does, however, keep `%|text|`, so add a case for that.
@oprypin
crystal: update keywords and builtins
f1b1e4f
@oprypin
crystal: fix string literals and escape sequences
3ee298d 
Update list of escapes. Support Unicode escape sequences.

Also remove the Ruby-specific `:@foo` symbol syntax, Crystal doesn't have it.
@oprypin
crystal: uppercase identifiers aren't always constants
2122590 
Make `FOO::Bar` be highlighted like `Foo::Bar` would be, rather than like `FOO`
@oprypin
crystal: annotations can be namespaced
3372173 
Highlight the entire inside part of `@[Foo::Bar]`, not just the `Foo` part

(these used to be named 'attributes' but the official name is 'annotations' now, so I also change that)
@oprypin
fixup! crystal: fix percent-strings, drop Ruby-specific arbitrary del…
24d05ce 
…imiters
@Anteru Anteru added this to the 2.7.4 milestone Jan 4, 2021
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Jan 4, 2021
@Anteru Anteru merged commit f8b097c into pygments:master Jan 4, 2021
@Anteru
Copy link
Collaborator

Anteru commented Jan 4, 2021

Merged, thanks a lot!

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Jan 6, 2021
@oprypin oprypin mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oprypin @Anteru