Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImgFormatter: Use the start position based on the length of text #1611

Merged
merged 1 commit into from Nov 28, 2020
Merged

ImgFormatter: Use the start position based on the length of text #1611

merged 1 commit into from Nov 28, 2020

Conversation

15b3
Copy link
Contributor

@15b3 15b3 commented Nov 26, 2020

Related #1213

Changed from calculating the start position as the number of characters multiplied by the number of widths of the letter "M" to using the get_size method of the PIL.ImageFont.ImageFont class and drawing the token from the calculated position for each token.

@Anteru Anteru linked an issue Nov 28, 2020 that may be closed by this pull request
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Nov 28, 2020
@Anteru Anteru added this to the 2.7.3 milestone Nov 28, 2020
@Anteru Anteru merged commit 1d51df1 into pygments:master Nov 28, 2020
@Anteru
Copy link
Collaborator

Anteru commented Nov 28, 2020

Merged, thanks a lot of for the timeline PR!

@15b3
Copy link
Contributor Author

15b3 commented Dec 1, 2020

Could I write my name on AUTHORS?

@Anteru
Copy link
Collaborator

Anteru commented Dec 1, 2020

@birkenfeld Any objections? I don't think we have established rules yet for which change warrants a mentioning in AUTHORS.

@birkenfeld
Copy link
Member

No objections.

@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Dec 5, 2020
15b3 added a commit to 15b3/pygments that referenced this pull request Dec 12, 2020
birkenfeld pushed a commit that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img formatter renders text at wrong position (on Windows?)
3 participants