testing turtle prefix names where reference starts with number #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Can you please take a look at the regexlint failures? It looks like some of your expression can be simplified. |
|
I did my best trying to align Turtle lexer with SPARQL and ShExC, not the other way. I also posted on RDFlib mailing list if some python developer familiar with RDF would consider helping with those RDF lexers: https://groups.google.com/g/rdflib-dev/c/hSGFT9jV61k In my last commit I needed to fix example.ttl which wasn't valid turtle. Now it passes validation with http://ttl.summerofcode.be/ |
|
Please let me know if there's anything else I should do in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1553
I don't work with python myself but I hope changes here are reasonable. ShExC lexer handles prefixed names where part after
:starts with number correctly. This change should only copy that part of ShExC lexer to Turtle lexer.