Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix punctuation not labeled in function definition in TypeScript #1511

Merged
merged 3 commits into from Jan 4, 2021
Merged

fix punctuation not labeled in function definition in TypeScript #1511

merged 3 commits into from Jan 4, 2021

Conversation

felixhao28
Copy link
Contributor

Fix #1510

@Anteru
Copy link
Collaborator

Anteru commented Aug 17, 2020

Thanks for the PR! Would you mind adding a small unit test for that?

@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Aug 17, 2020
@Anteru Anteru self-assigned this Aug 17, 2020
@Anteru Anteru added this to the 2.7 milestone Aug 17, 2020
@felixhao28
Copy link
Contributor Author

The tests/test_javascript.py seems limited to CoffeeScript. I don't know if I should add another file for typescript tests.

@Anteru
Copy link
Collaborator

Anteru commented Aug 22, 2020

Yes, test_javascript would be the right place to put the test.

Anteru
Anteru requested changes Aug 23, 2020
View reviewed changes
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for this.

@felixhao28
Copy link
Contributor Author

Test case added.

@Anteru Anteru modified the milestones: 2.7, 2.8 Sep 12, 2020
Mesteery
Mesteery reviewed Jan 2, 2021
View reviewed changes
tests/test_javascript.py Outdated Show resolved Hide resolved
@felixhao28 @Mesteery
Update tests/test_javascript.py
05effda 
Co-authored-by: Mestery <48163546+Mesteery@users.noreply.github.com>
@Anteru Anteru merged commit 5b432df into pygments:master Jan 4, 2021
@Anteru Anteru modified the milestones: 2.8, 2.7.4 Jan 4, 2021
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@Anteru Anteru Anteru requested changes

Assignees

@Anteru Anteru

Labels
None yet
Projects
None yet
Milestone
2.7.4
Development

Successfully merging this pull request may close these issues.

Typescript: Name.Other over extends to punctuation in function definition
3 participants
@felixhao28 @Anteru @Mesteery