Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDDL lexer (Fix #1239) #1379

Merged
merged 14 commits into from
Feb 14, 2021
Merged

Add CDDL lexer (Fix #1239) #1379

merged 14 commits into from
Feb 14, 2021

Conversation

serianox
Copy link
Contributor

@serianox serianox commented Feb 2, 2020

Integrate lexer from Fabian Neumann.

@serianox serianox mentioned this pull request Feb 2, 2020
pygments/lexers/cddl.py Outdated Show resolved Hide resolved
@Anteru
Copy link
Collaborator

Anteru commented Feb 7, 2021

Can you please resolve the conflicts and update the example file? See Contributing.md for the new test system, it boils down to moving the file and generating a golden output.

@Anteru Anteru added this to the 2.8 milestone Feb 7, 2021
@Anteru Anteru self-requested a review February 12, 2021 18:33
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests to the new system.

@serianox
Copy link
Contributor Author

I apologize, my disk crashed in the meantime. 😃
I just need to fix the regexlint reports and it should be good to go.

@Anteru
Copy link
Collaborator

Anteru commented Feb 14, 2021

Merged, thanks!

@Anteru Anteru merged commit 1e2efc0 into pygments:master Feb 14, 2021
@Anteru Anteru self-assigned this Feb 14, 2021
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Feb 14, 2021
@serianox serianox deleted the cddl branch February 14, 2021 08:23
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants