Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygments 2.5.0 is globally installing its tests under the "tests" module #1280

Closed
thehcma opened this issue Nov 26, 2019 · 5 comments
Closed
Labels
S-major severity: major
Milestone

Comments

@thehcma
Copy link

thehcma commented Nov 26, 2019

This obviously pollutes the global top-level tests module.

/..../lib/python3.7/site-packages/tests/
├── dtds
│   ├── HTML4.dcl
│   ├── HTML4.dtd
│   ├── HTML4-f.dtd
│   ├── HTML4-s.dtd
│   ├── HTML4.soc
│   ├── HTMLlat1.ent
│   ├── HTMLspec.ent
│   └── HTMLsym.ent
├── examplefiles
│   ├── 99_bottles_of_beer.chpl
│   ├── abnf_example1.abnf
│   ├── abnf_example2.abnf
│   ├── AcidStateAdvanced.hs
│   ├── addressbook.proto
│   ├── ahcon.f
│   ├── all.nit
│   ├── AlternatingGroup.mu
│   ├── antlr_ANTLRv3.g
│   ├── antlr_throws
│   ├── apache2.conf
│   ├── as3_test2.as
│   ├── as3_test3.as
│   ├── as3_test.as
│   ├── aspx-cs_example
│   ├── autoit_submit.au3
...
...
@Anteru
Copy link
Collaborator

Anteru commented Nov 26, 2019

Uh, that's not good. It shouldn't be installing the tests at all, but then again, nothing changed on the build script side. @birkenfeld any idea what went wrong here? Is this related to the py.test migration by any chance?

@Anteru Anteru added this to the 2.5.1 milestone Nov 26, 2019
@Anteru Anteru added the S-major severity: major label Nov 26, 2019
@Anteru
Copy link
Collaborator

Anteru commented Nov 26, 2019

The tests folder is mentioned in MANIFEST.in, but that file has not changed in years. Maybe it's due to __init__.py being present in tests, and find_package in setup.py should become: packages = find_packages(exclude=['tests']),

@birkenfeld
Copy link
Member

Yeah, that looks to be the culprit.

Oh well, no big deal, time for a brown-paper-bag release.

@Anteru Anteru closed this as completed in 9e1f1e1 Nov 26, 2019
@thehcma
Copy link
Author

thehcma commented Nov 26, 2019

Thanks for fix!

@Anteru
Copy link
Collaborator

Anteru commented Nov 26, 2019

2.5.1 is live now with the fix. Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-major severity: major
Projects
None yet
Development

No branches or pull requests

3 participants