Javascript lexer misclassifies async

[Anteru]

(Original issue 1446 created by Xavdidtheshadow on 2018-06-14T05:05:44.112262+00:00)

Hi there!

When using the JS lexer, the "await" keyword is listed as "Token.Name.Other" rather than "Token.Keyword.Reserved". This extends to other related tokens, such as "async"

My test input was:

#!javascript

const j = async () => await Promise.resolve(3)

[Anteru]

(Original comment by peterbe on 2019-02-06T15:31:12.023318+00:00)

Demonstrated here: http://pygments.org/demo/6783285/

[Anteru]

(Original comment by jonluca on 2019-02-16T04:50:23.374630+00:00)

There is also an ancillary issue to JavaSript's async keyword - it's incorrectly colored when it is the name of a variable in a function definition, as below:

function testFunc(param1, param2, async){
    // do something
}

An example can be found here, near the bottom of the page, at XMLHttpRequest.prototype.open = function (method, url, async, user, pass).

[Domiii]

This forces me to switch from minted to listings for my writing needs.

Great project, but insufficient for my use case :/

[Anteru]

We are quite interested in improving any lexer -- but we don't have the bandwidth nor the knowledge of all languages to do it, so we rely on the community to contribute. Would you mind preparing a PR for the issues you're facing? I'll be happy to review it so we can get it integrated into Pygments.

[Domiii]

I just checked and it does list async and await as keywords.

Not sure why it did not highlight them? I used v2.7.3.

Here it is in the lexer.

[xavdid]

(I'm the OP from bitbucket)

Looks like this was fixed in #1605. I had no idea it was so straightforward or I would have just done it back in 2018 🙈

Thanks a bunch!

[Anteru]

@xavdid Thanks! :) Given it was merged 29 days ago, that means it should be in 2.7.3 -- @Domiii , can you please double-check you're using 2.7.3?

[Domiii]

Ok, I found the problem. I assumed it was using my pip-installed version, but it in fact used some version that was installed by Anaconda and of the wrong version. Apologies!

(On a separate note: Having a -v (--version) flag helps with this. I got the version via pip list pygments, not knowing I had to use conda show pygments to get the right one. Considering the chaos that Python and it's many difference environments bring, having your own dedicated version command would be super helpful :) )