Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pyjwt>=2.4.0 to avoid CVE-2022-29217 #2333

Merged
merged 1 commit into from Oct 25, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 13, 2022

Fixes #2260.

Avoid CVE-2022-29217 by requiring pyjwt>=2.4.0.

PyGithub requires pyjwt>=2.0, so there's nothing to stop end users updating, and if they do a fresh install they'll get a newer version.

But it's a good idea to require at least the fixed 2.4.0 as a minimum version too.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 98.81% // Head: 98.88% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2e5af00) compared to base (437ff84).
Patch has no changes to coverable lines.

❗ Current head 2e5af00 differs from pull request most recent head 3dd3921. Consider uploading reports for the commit 3dd3921 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
+ Coverage   98.81%   98.88%   +0.07%     
==========================================
  Files         109      108       -1     
  Lines       11267    11172      -95     
==========================================
- Hits        11133    11047      -86     
+ Misses        134      125       -9     
Impacted Files Coverage Δ
github/Repository.py 97.14% <0.00%> (-0.02%) ⬇️
github/WorkflowRun.py 100.00% <0.00%> (ø)
github/Artifact.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sfdye sfdye merged commit a71cd37 into PyGithub:master Oct 25, 2022
@hugovk hugovk deleted the bump-pyjwt branch October 25, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update pyjwt to 2.4,0 or later
3 participants