Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class Artifact (#2313) #2319

Merged
merged 5 commits into from Oct 25, 2022
Merged

Add class Artifact (#2313) #2319

merged 5 commits into from Oct 25, 2022

Conversation

lexa
Copy link
Contributor

@lexa lexa commented Sep 27, 2022 •
edited by sfdye

Github workflow runs produce downloadable artifacts, add a class to represent them.

PyGithub doesn't use Artifacts in its CI, so i have to use an external project for the test

Fixes #2313

@lelegard lelegard mentioned this pull request Sep 29, 2022
Closed
@EnricoMi EnricoMi mentioned this pull request Sep 30, 2022
Open
@sfdye
Copy link
Member

sfdye commented Oct 13, 2022

@lexa Thank you for your contributing. Could you fix the unit tests? In the meantime, let me see if I can fix the setting where first-time contributor needs approval to run Github workflow.

@sfdye
Copy link
Member

sfdye commented Oct 13, 2022

Much better
CleanShot 2022-10-13 at 08 24 51

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@17b44d8). Click here to learn what that means.
Patch coverage: 90.52% of modified lines in pull request are covered.

❗ Current head c99d11c differs from pull request most recent head 93f41cb. Consider uploading reports for the commit 93f41cb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2319   +/-   ##
=========================================
  Coverage          ?   98.81%           
=========================================
  Files             ?      109           
  Lines             ?    11267           
  Branches          ?        0           
=========================================
  Hits              ?    11133           
  Misses            ?      134           
  Partials          ?        0
Impacted Files Coverage Δ
github/Artifact.py 89.41% <89.41%> (ø)
github/Repository.py 97.16% <100.00%> (ø)
github/WorkflowRun.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alekseifedotov
Copy link

@sfdye all the tests are passing now.

Aleksei Fedotov added 5 commits October 25, 2022 10:57
@sfdye
Add class Artifact (PyGithub#2313)
6783164 
Github workflow runs produce downloadable artifacts, add a class to
represent them.
@sfdye
Add delete method for Artifact (PyGithub#2313)
4fed6fd 
Add a method to delete a stored artifact from Github Actions.
@sfdye
Add listing of artifacts in the repository (PyGithub#2313)
720dbe2 
Implement calls for listing Github Actions artifacts linked to a
repository.

The test runs on an external repository because PyGithub doesn't have
any artifacts in its CI.
@sfdye
Add a test for deleting artifacts (PyGithub#2313)
c333a99
@sfdye
Add a test for invalid artifact ID (PyGithub#2313)
93f41cb
@sfdye sfdye merged commit 437ff84 into PyGithub:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfdye sfdye sfdye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Artifact support ?
4 participants
@lexa @sfdye @codecov-commenter @alekseifedotov