New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve signature of Repository.create_repo #2118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start, I have some concerns inline.
The docstring stated that `"*"` and `"none"` were valid values for the organization, but neither was actually supported (unless your organization was called `"none"`). Remove the misleading information from the docstring, and add support for passing in an actual `Organization` object, for better typing and reliability properties. Fixes #2116
Finally came around to writing a test, suite passes locally (at least when running Not sure how the replay files are supposed to get generated to I created one by hand copying the one from the regular call, and copying over the org data from the fork's |
@s-t-e-v-e-n-k are there additional things you need me to change? |
Ping, is this still of interest or should I just close it? |
Codecov Report
@@ Coverage Diff @@
## master #2118 +/- ##
==========================================
- Coverage 98.90% 98.89% -0.01%
==========================================
Files 108 108
Lines 11131 11133 +2
==========================================
+ Hits 11009 11010 +1
- Misses 122 123 +1
Continue to review full report at Codecov.
|
The docstring stated that
"*"
and"none"
were valid values for theorganization, but neither was actually supported (unless your
organization was called
"none"
).Remove the misleading information from the docstring, and add support
for passing in an actual
Organization
as that's convenient for typing and clarity.Fixes #2116