Create repo from template #2090
Conversation
…hub into create-from-template
Create from template
commit 6452ddf Author: Steve Kowalik <steven@wedontsleep.org> Date: Sun Oct 24 15:21:31 2021 +1100 Add Repository.rename_branch method (PyGithub#2089) The GitHub API exposes an endpoint to rename a branch, so we should support calling it. Sadly, there is not enough information to add that method to the Branch class, so expose it in the Repository object. Fixes PyGithub#1901 commit c8a945b Author: Claire Johns <42869556+johnsc1@users.noreply.github.com> Date: Sun Oct 24 00:15:31 2021 -0400 Add function to delete pending reviews on a pull request (PyGithub#1897) Add a delete method to PullRequestReview to allow dismissing them. Fixes PyGithub#1856 Co-authored-by: bagashvilit <bagashvilit@allegheny.edu> Co-authored-by: WonjoonC <chos@allegheny.edu> commit f1faf94 Author: Steve Kowalik <steven@wedontsleep.org> Date: Fri Oct 22 08:39:31 2021 +1100 Cover all code paths in search_commits (PyGithub#2087) The search_commits method was only very lightly tested, meaning over half of it was not covered. Write another test case, covering all code paths.
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 98.92% 98.88% -0.04%
==========================================
Files 108 108
Lines 11120 11170 +50
==========================================
+ Hits 11000 11046 +46
- Misses 120 124 +4
Continue to review full report at Codecov.
|
simkimsia
force-pushed
the
create-repo-from-template
branch
from
e160cd5
to
6b07883
Compare
|
Sorry @s-t-e-v-e-n-k what's the blocker for merging this? Anything I can do to make this ok? |
|
Hi @s-t-e-v-e-n-k, what's the blocker for merging this? Anything I can do to make this ok? |
|
@simkimsia I'm sorry, life has gotten in the way of my free time -- lint now fails, |
|
will look at this later. thank you 🙏 |
♻Rewrite to make things conform closer to main branch ♻ Fix f string ♻ Change to f string And also switch to the accept header recommended in https://docs.github.com/en/rest/reference/repos#create-a-repository-using-a-template ♻ Move away from `application/vnd.github.baptiste-preview+json` ✅Make tests pass ✅Fix tests 🎨 FIX: the formatting by running `tox -elint`
simkimsia
force-pushed
the
create-repo-from-template
branch
from
6b07883
to
8531073
Compare
|
@s-t-e-v-e-n-k fixed using |
|
@s-t-e-v-e-n-k any changes i need to do? |
|
@s-t-e-v-e-n-k sorry i have to followup. I will follow up in jan 15th next time. |
|
@s-t-e-v-e-n-k happy new year. just following up on this. Any changes i need to make? |
|
This is a much needed change, the solution looks solid and simple. Can we get it merged? Also, I suggest closing the other, now stale PR tackling the same problem: #1395 |
|
@s-t-e-v-e-n-k hello, any news on when this might get merged in? |
|
I'm formally giving up. If anyone wants to carry on, by all means. No hard feelings. Thank you |
|
@s-t-e-v-e-n-k Hey, do you think we are ready to merge this? Thank you! |
|
really want this feature... |
|
@s-t-e-v-e-n-k Do we plan to merge this? would really like this feature. |
|
Also really need this feature. Can we have this merged please? @s-t-e-v-e-n-k . I see this would unblock not just me, but a lot of others. Also the PR looks pretty solid - any reason why we cannot merge this? Please take a look. |
|
@adamtheturtle @jzelinskie @nhomar @jacquev6 @sfdye @s-t-e-v-e-n-k |
|
Sorry folks for the long wait, I am merging this now. But the new release will probably have to wait until I am back from vacation. |
|
Just published v1.56 |
|
Thank you @sfdye |
Based on the comments made in this review #2088 (review)
i made extra effort to redo the PR so that all the lint related changes are reverted.
This is to solve #1395 and #1974
With the last commit being 8b638c5
And this is a continuation of the PR in #2012 and #2088
@harismuha123 I have tried to resolve merge conflicts and hope that @s-t-e-v-e-n-k can approve this PR.