Cover all code paths in search_commits #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search_commits method was only very lightly tested, meaning over half of it was not covered. Write another test case, covering all code paths.
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 98.87% 98.91% +0.04%
==========================================
Files 108 108
Lines 11109 11109
==========================================
+ Hits 10984 10989 +5
+ Misses 125 120 -5
Continue to review full report at Codecov.
|
simkimsia
added a commit
to simkimsia/PyGithub
that referenced
this pull request
Oct 24, 2021
commit 6452ddf Author: Steve Kowalik <steven@wedontsleep.org> Date: Sun Oct 24 15:21:31 2021 +1100 Add Repository.rename_branch method (PyGithub#2089) The GitHub API exposes an endpoint to rename a branch, so we should support calling it. Sadly, there is not enough information to add that method to the Branch class, so expose it in the Repository object. Fixes PyGithub#1901 commit c8a945b Author: Claire Johns <42869556+johnsc1@users.noreply.github.com> Date: Sun Oct 24 00:15:31 2021 -0400 Add function to delete pending reviews on a pull request (PyGithub#1897) Add a delete method to PullRequestReview to allow dismissing them. Fixes PyGithub#1856 Co-authored-by: bagashvilit <bagashvilit@allegheny.edu> Co-authored-by: WonjoonC <chos@allegheny.edu> commit f1faf94 Author: Steve Kowalik <steven@wedontsleep.org> Date: Fri Oct 22 08:39:31 2021 +1100 Cover all code paths in search_commits (PyGithub#2087) The search_commits method was only very lightly tested, meaning over half of it was not covered. Write another test case, covering all code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search_commits method was only very lightly tested, meaning over
half of it was not covered. Write another test case, covering all code
paths.