New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for repository autolink references #2016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking like a great start. I have some concerns, one of which I've marked inline, and further, if this API is in beta, does it require a custom Accept header like many other examples in this code base?
As far as I can tell a custom Accept header is not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fantastic, just requires tests for the new methods.
Codecov ReportBase: 98.81% // Head: 98.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
- Coverage 98.81% 98.80% -0.01%
==========================================
Files 109 110 +1
Lines 11267 11305 +38
==========================================
+ Hits 11133 11170 +37
- Misses 134 135 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi, I looked into creating tests for this, but I'm unsure how to properly get the replay data I need for them. |
I can't record replay data since it changes the Repository.setUp replay data to my fork, which makes all the other tests fail. I can't record data using the main repository, since I don't have write access. |
I guess I could change the test case to use my fork only for these methods? But that doesn't really sound like a great solution. |
I could also manually change the replay data (replace mentions of my fork with the main repo) I guess, if that's okay. Edit: That's what I will do for the "Repository" test. For the "Autolink" test case I create I will use my fork, I see that's what others did too. |
Done. I also undrafted since I'm fairly optimistic this API is stable enough / even if they end up changing something after "Beta" we can just adjust the code again. |
& rebased for good meassure |
@s-t-e-v-e-n-k Do you have an update on the review status? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@s-t-e-v-e-n-k Can you re-open this? |
Can we please re-open this ticket and get the code merged. We're in need of the feature and it'd be better to have it as part of PyGithub instead of having to use a custom implementation. |
@sfdye Can we get this feature into the next release? It would be a waste to throw away all the work that already went into it. |
Re-opened, if someone could resolve the conflicts I will review |
Done. |
Looks like one of the CI tests failed. And upon closer inspection it seems that the code needs to be formatted by black to pass the lint check and the import order needs to be updated. black: https://github.com/PyGithub/PyGithub/actions/runs/3344110825/jobs/5538083016#step:5:39 Both should be fixed by running the pre-commit hook on the PR branch. |
Adds support for repository autolinks. I put this on draft, since the API for it is beta and subject to change.
This will (actually :) ) close #1293.