Add Github Actions Secrets to organization

[peresypkinamarina]

Add functionality to create and delete Secrets for Organizations.
Usage:

g.get_organization("test").create_secret("secret-name", "unencrypted-value", visibility=all/private/selected, selected_repository_ids=[]) # selected_repository_ids in case when visibility=selected
g.get_organization("test").delete_secret("secret-name")

[peresypkinamarina]

@s-t-e-v-e-n-k Could you please check it?

[s-t-e-v-e-n-k]

This is looking excellent, I just have one issue before merging.

[s-t-e-v-e-n-k]

It feels more true to our interpretation of the API to call this selected_repositories and then allow users to pass either Repository objects or ids, and then transform them to a list of IDs when we make the PUT request.

[peresypkinamarina]

@s-t-e-v-e-n-k Thank you for review.
I made changes to pass list of repos, similar approach as in Organization.create_team. Please check it

[s-t-e-v-e-n-k]

Loving the direction, I just have a few more concerns.

[s-t-e-v-e-n-k]

This isn't guarded like the assert check, which means that if you don't pass visibility and do pass selected_repositories something that isn't a list of Repository objects, then we throw an exception.

Do we need to be more careful here and assert that it's an empy list (or NotSet) if visibility isn't selected?

[peresypkinamarina]

yeah, it this was not covered, thanks
Made changes to handle cases:
visibility==selected and selected_repositories is NotSet
visibility!=selected and selected_repositories is not NotSet

@s-t-e-v-e-n-k Please check it

[s-t-e-v-e-n-k]

I think you need to mark the visibility parameter with it's default value. Also, what does type checking return if you call create_secret() with no selected_repositories?

[peresypkinamarina]

Marked and set NotSet as default value for selected_repositories

[s-t-e-v-e-n-k]

Lint failed, fix that up and we can get this merged.

[peresypkinamarina]

Lint failed, fix that up and we can get this merged.

@s-t-e-v-e-n-k fixed, please check

[s-t-e-v-e-n-k]

Type hints this time:

  lint run-test: commands[1] | mypy github tests
  github/Organization.pyi:144: error: Name "PublicKey" is not defined

[peresypkinamarina]

lint run-test: commands[1] | mypy github tests

fixed, please trigger check again