Fix: #1671 Convert Python Bool to API Parameter for Authenticated User Notifications #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github/AuthenticatedUser.py
Outdated
| if participating is not github.GithubObject.NotSet: | ||
| params["participating"] = participating | ||
| # convert True, False to true, false for api parameters | ||
| params["participating"] = str(participating).lower() if isinstance(participating, bool) else participating |
There was a problem hiding this comment.
At this point, you know participating is set and is a bool, so I think you could be simplified to:
params["participating"] = "true" if participating else "false"
There was a problem hiding this comment.
And for all as well
There was a problem hiding this comment.
Okay sounds good. @s-t-e-v-e-n-k please review the change.
|
@s-t-e-v-e-n-k could you please review and merge? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1671
Converts Python Bools
allandparticipatingto lower case string that are valid API parameters.Trueis converted to"true"