Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding headers in GithubException is a breaking change #1931

Merged

Conversation

s-t-e-v-e-n-k
Copy link
Collaborator

Since exporting headers in GithubException might require passing them in
a constructor for client code, shift it as a breaking change so users
watch out for it.

Since exporting headers in GithubException might require passing them in
a constructor for client code, shift it as a breaking change so users
watch out for it.
@codecov-commenter
Copy link

Codecov Report

Merging #1931 (fd3dfb2) into master (8aebd94) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1931   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         108      108           
  Lines       11064    11064           
=======================================
  Hits        10937    10937           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aebd94...fd3dfb2. Read the comment docs.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit d1644e3 into PyGithub:master Apr 26, 2021
@s-t-e-v-e-n-k s-t-e-v-e-n-k deleted the shift-githubexception-in-changes branch October 21, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants