Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key_id could be int on Github Enterprise #1894

Merged
merged 2 commits into from Mar 26, 2021
Merged

key_id could be int on Github Enterprise #1894

merged 2 commits into from Mar 26, 2021

Conversation

MeggyCal
Copy link
Contributor

Closes #1878

s-t-e-v-e-n-k
s-t-e-v-e-n-k requested changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking excellent, just one minor niggle.

tests/PublicKey.py Show resolved Hide resolved
s-t-e-v-e-n-k
s-t-e-v-e-n-k reviewed Mar 25, 2021
View reviewed changes
github/PublicKey.py Outdated Show resolved Hide resolved
@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit ad124ef into PyGithub:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

Assignees
No one assigned
Labels
hackweek-20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in repr(PublicKey)
2 participants
@MeggyCal @s-t-e-v-e-n-k