Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to Github API changes regarding emails #1890

Merged
merged 2 commits into from Mar 24, 2021
Merged

Adjust to Github API changes regarding emails #1890

merged 2 commits into from Mar 24, 2021

Conversation

MeggyCal
Copy link
Contributor

Closes #1852

s-t-e-v-e-n-k
s-t-e-v-e-n-k requested changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a great start, I have some concerns inline.

github/AuthenticatedUser.py Outdated Show resolved Hide resolved
github/AuthenticatedUser.py Outdated Show resolved Hide resolved
github/AuthenticatedUser.py Outdated Show resolved Hide resolved
tests/AuthenticatedUser.py Outdated Show resolved Hide resolved
@MeggyCal MeggyCal force-pushed the master branch 5 times, most recently from ac86ebe to 85cc405 Compare March 23, 2021 16:17
@MeggyCal MeggyCal force-pushed the master branch 2 times, most recently from a13f6df to 9c0c522 Compare March 24, 2021 08:21
s-t-e-v-e-n-k
s-t-e-v-e-n-k reviewed Mar 24, 2021
View reviewed changes
tests/AuthenticatedUser.py Outdated
@@ -100,12 +100,12 @@ def testEditWithAllArguments(self):

def testEmails(self):
self.assertEqual(
self.user.get_emails(),
[item.email for item in self.user.get_emails()],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to pull this out of the list comprehension so you check at least primary and hopefully the other two for the first element.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 2c77cfa into PyGithub:master Mar 24, 2021
@DamianZaremba DamianZaremba mentioned this pull request Jun 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

Assignees
No one assigned
Labels
hackweek-20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthenticatedUser.get_emails() returned data changed to list of dicts
2 participants
@MeggyCal @s-t-e-v-e-n-k