Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client_id/client_secret authentication #1888

Merged

Conversation

s-t-e-v-e-n-k
Copy link
Collaborator

Authenticating via client_id and client_secret is dangerous, since they
appended to the query string, and can be easily seen from the URL.

client_id/client_secret have been deprecated since May 2020, and ignored
by GitHub since late 2020, so it's high time they were removed.

Authenticating via client_id and client_secret is dangerous, since they
appended to the query string, and can be easily seen from the URL.

client_id/client_secret have been deprecated since May 2020, and ignored
by GitHub since late 2020, so it's high time they were removed.
@codecov-io
Copy link

Codecov Report

Merging #1888 (d054984) into master (ddd437a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
- Coverage   98.88%   98.88%   -0.01%     
==========================================
  Files         108      108              
  Lines       11052    11042      -10     
==========================================
- Hits        10929    10919      -10     
  Misses        123      123              
Impacted Files Coverage Δ
.../runner/work/PyGithub/PyGithub/github/MainClass.py 95.56% <0.00%> (-0.08%) ⬇️
.../runner/work/PyGithub/PyGithub/github/Requester.py 98.44% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd437a...d054984. Read the comment docs.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 901af8c into PyGithub:master Mar 23, 2021
@s-t-e-v-e-n-k s-t-e-v-e-n-k deleted the remove-client-secret-password branch October 21, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants