New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the 'visibility' attribute on the Repository object #1872
Conversation
559508f
to
75fff25
Compare
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
==========================================
- Coverage 98.87% 98.86% -0.02%
==========================================
Files 108 108
Lines 11044 11055 +11
==========================================
+ Hits 10920 10929 +9
- Misses 124 126 +2
Continue to review full report at Codecov.
|
Rebase on master, please -- I've deleted those files that are conflicting. |
75fff25
to
e12d559
Compare
Hi @s-t-e-v-e-n-k, I've rebased on top of master |
Any ETA on getting this merged and released? |
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
==========================================
- Coverage 98.86% 98.84% -0.02%
==========================================
Files 108 108
Lines 11064 11071 +7
==========================================
+ Hits 10938 10943 +5
- Misses 126 128 +2 Continue to review full report at Codecov.
|
Does this also require changes to MainClass.get_repo to add in the Accept header? |
It does not, I have checked. |
Adds support for the 'visibility' attribute on the Repository object. Closes #1446.
I updated the affected replay tests manually (not seeing a BeaverSoftware org?). I added the header to reflect the new request we'll send, and added
"visibility":"public"
next to"private":false
in all response objects.I also smoke tested this against our real enterprise account:
Thank you for the useful library and taking the time to consider this contribution!