fix bad assertions in github.Project.edit #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertions in github.Project.edit looked like the result of a bad copy-paste operation: they were all making assertions about the `name` parameter. This commit fixes them so they are checking different parameters.
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 51 51
Lines 2677 2677
=======================================
Hits 2644 2644
Misses 33 33 Continue to review full report at Codecov.
|
pascal-hofmann
approved these changes
Jan 7, 2021
|
Hey folks, is it possible to merge this pr, or does it need any additional work? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions in github.Project.edit looked like the result of a bad
copy-paste operation: they were all making assertions about the
nameparameter. This commit fixes them so they are checking different parameters.