Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fixing paths for codecov.io to cover all project files #1813

Merged
merged 3 commits into from Mar 8, 2021

Conversation

karsten-wagner
Copy link
Contributor

This fix will change the codecov.io configuration to replace automatic path handling with manual fixes. This is needed to properly reflect all project files in the codecov.io report, since with automatic path fixes it is covering only roughly 50% of the code (compare number of files in the project and those reflected on codecov.io).

@karsten-wagner
Copy link
Contributor Author

This PR aims to fix #1812.

Feel free to apply or to address this to codecov.io to have them fix the automatic path fixing...

@codecov-io
Copy link

Codecov Report

Merging #1813 (83ba4f7) into master (34d097c) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   98.76%   98.89%   +0.12%     
==========================================
  Files          51      107      +56     
  Lines        2677    10992    +8315     
==========================================
+ Hits         2644    10870    +8226     
- Misses         33      122      +89     
Impacted Files Coverage Δ
github/__init__.py 100.00% <0.00%> (ø)
github/CheckSuite.py 99.26% <0.00%> (ø)
github/Gist.py 100.00% <0.00%> (ø)
github/Hook.py 100.00% <0.00%> (ø)
github/ContentFile.py 100.00% <0.00%> (ø)
github/Download.py 100.00% <0.00%> (ø)
github/Label.py 100.00% <0.00%> (ø)
github/IssueEvent.py 100.00% <0.00%> (ø)
github/Project.py 98.43% <0.00%> (ø)
github/SourceImport.py 100.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d097c...83ba4f7. Read the comment docs.

@karsten-wagner
Copy link
Contributor Author

Note all files are reported unchanged in the code coverage comment, but the number of covered files increases from 51 to 107.

codecov.yml Outdated Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
karsten-wagner and others added 2 commits January 5, 2021 15:17
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
@karsten-wagner
Copy link
Contributor Author

@s-t-e-v-e-n-k , sure - reworked the comment(s) as per your suggestion...

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit b2232c8 into PyGithub:master Mar 8, 2021
karsten-wagner added a commit to karsten-wagner/PyGithub that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants