Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attributes "maintain" and "triage" to class "Permissions" #1810

Merged
merged 4 commits into from Mar 24, 2021

Conversation

karsten-wagner
Copy link
Contributor

@karsten-wagner karsten-wagner commented Dec 30, 2020

Addresses feature request in #1809

  • Added attribute maintain to class Permissions
  • Added attribute triage to class Permissions
  • Verified documentation build covers the new attributes
  • Verified Github API response on team permissions is properly reflected in updated class
  • Linting successful

Fixes #1809

@karsten-wagner
Copy link
Contributor Author

The code coverage report does not seem to consider all files in the github folder. It's not really clear to me why test coverage should be lower based on my recent change than before. Please advise how to read that report and how to ensure code coverage remains at least on same level?!

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #1810 (68a0e16) into master (34d097c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   98.76%   98.75%   -0.02%     
==========================================
  Files          51       50       -1     
  Lines        2677     2653      -24     
==========================================
- Hits         2644     2620      -24     
  Misses         33       33              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d097c...68a0e16. Read the comment docs.

@karsten-wagner
Copy link
Contributor Author

I believe this would need #1813 to fix the code coverage calculation issue mentioned before.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 7687961 into PyGithub:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes "maintain" and "triage" missing in class "Permissions"
3 participants