Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding github actions secrets #1681

Merged
merged 9 commits into from Mar 6, 2021
Merged

Adding github actions secrets #1681

merged 9 commits into from Mar 6, 2021

Conversation

pdex
Copy link
Contributor

@pdex pdex commented Sep 2, 2020

This adds the ability to create repository secrets.

If merged this PR will add a dependency on pynacl.

@codecov-commenter
Copy link

Codecov Report

Merging #1681 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1681   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          48       48           
  Lines        2561     2561           
=======================================
  Hits         2527     2527           
  Misses         34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec4f15...0917153. Read the comment docs.

@pdex pdex marked this pull request as ready for review September 3, 2020 22:25
@pdex pdex changed the title WIP: Adding github actions secrets Adding github actions secrets Sep 9, 2020
@latacora-tomekr
Copy link

Could we add List Organization Secrets (https://docs.github.com/en/free-pro-team@latest/rest/reference/actions#list-organization-secrets) to this as well?

@geerlingguy
Copy link

Tested and works great for my needs! (I just needed to loop through about 100 repositories and add a secret, and it worked for that, as well as updating the secret).

It would be great to support the other methods as well, but I'd love to see this merged as a start as repo secrets are by far the most annoying thing to manage for personal account repositories. At least for orgs, you can add one secret for all the org's repos!

@pdex
Copy link
Contributor Author

pdex commented Nov 21, 2020

@sfdye or @s-t-e-v-e-n-k could you please address this PR? thanks.

@sfdye
Copy link
Member

sfdye commented Nov 21, 2020

will check

@sfdye
Copy link
Member

sfdye commented Nov 21, 2020

@pdex Could you resolve the merge conflicts first?

@akhmerov
Copy link

What's the status of the PR? The only merge conflict appears to be in requirements / setup.py

I'd be happy to resolve it from a fork if necessary, but I'm not sure if that's the main or only open question.

@pdex
Copy link
Contributor Author

pdex commented Mar 1, 2021

@akhmerov thanks for the bump, I'll get that sorted.

@pdex
Copy link
Contributor Author

pdex commented Mar 1, 2021

@sfdye or @s-t-e-v-e-n-k the merge conflict has been resolved.

Dependency on pynacl has been set to "pynacl>=1.4.0" this is now in line with how the other dependencies have been specified.

@sfdye
Copy link
Member

sfdye commented Mar 2, 2021

Thanks for resolving the conflicts. Looks like the lint checks failed, you can fix it by following:

https://github.com/PyGithub/PyGithub/blob/master/CONTRIBUTING.md#coding-style

@pdex
Copy link
Contributor Author

pdex commented Mar 2, 2021

@sfdye all checks are passing.

requirements.txt Outdated Show resolved Hide resolved
Co-authored-by: Liuyang Wan <tsfdye@gmail.com>
@pdex
Copy link
Contributor Author

pdex commented Mar 4, 2021

@sfdye Permission to merge?

@sfdye
Copy link
Member

sfdye commented Mar 4, 2021

Yes, merge at your will

@akhmerov
Copy link

akhmerov commented Mar 4, 2021

Could secrets also be included in a new release after the merge?

@sfdye
Copy link
Member

sfdye commented Mar 4, 2021 via email

@pdex
Copy link
Contributor Author

pdex commented Mar 6, 2021

@sfdye I don't have write permission, could you please merge?

@sfdye sfdye merged commit c90c050 into PyGithub:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants