AuthenticatedUser.get_notifications() boolean query parameters always return true.

[newswangerd]

Description

Setting all and participating filters don't filters doesn't do anything.

all=True and participating=True should filter notifications, but instead get_notifications always returns the full list of notifications.

Steps to reproduce

from github import Github
g = Github("secret")
user = g.get_user()

# all=False is broken
notifications = user.get_notifications(all=False)

# returns 371
print(notifications.totalCount)

notifications = user.get_notifications(all=True)

# returns 371
print(notifications.totalCount)

[s-t-e-v-e-n-k]

Based on the GitHub API docs and the code, we're sending the correct parameters, so we're entirely at the mercy of whatever GitHub sends back.

[newswangerd]

@s-t-e-v-e-n-k The github API seems to do the right thing. https://api.github.com/notifications?all=false only returns my unread notifications. I did notice that https://api.github.com/notifications?all=False (with the capital F) returns all my notifications.

It looks like the client sets the all param as a boolean:

PyGithub/github/AuthenticatedUser.py

Line 978 in 07e29fe

params["all"] = all

Since python booleans use capital letters, I'm wondering if this getting set as ?all=False when the params get converted to a string. If that's the case, there might be other params that are broken as well, such as participating

[brighton1101]

I am running into this problem with participating and with all. I believe @newswangerd is correct in that the api does not assume False == false in the url params.

Am willing to put together a PR if you're interested in having this fixed.

[s-t-e-v-e-n-k]

Sounds like we need to say "true" if all else "false". I would welcome a PR! Make sure to include "Fixes #1671" in the commit message.