fix segfault in display.update #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some kinds of inputs = list of rects, also incorrect input will segfault it This means the aliens example segfaults in 2.1.1 regression from 17298e4#diff-e6e90037fae974fd4cb565f9dcde4d003062eb172fb5c4132e2b2d994c29d8ad |
illume
force-pushed
the
ankith26-display-update-fix
branch
2 times, most recently
from
1e473bf
to
0acc385
Compare
We have an interactive test, because there's no easy way to get the screen pixels and see if the window only updates in the areas given. This is not perfect, because when running interactive the tests run twice... once interactive, and once not. But it's still better than repeating all the tests?
illume
force-pushed
the
ankith26-display-update-fix
branch
from
0acc385
to
11ade32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression of the latest 2.1.1 release, display.update can segfault on some kinds of inputs