Fix selection of manylinux to build #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illume
force-pushed
the
manylinux2014
branch
6 times, most recently
from
adfdc1b
to
62e8362
Compare
So that more recent manylinux2010 and 2014 wheels are made in addition to the older manylinux1 builds.
ankith26
approved these changes
Oct 31, 2021
| @@ -33,12 +33,14 @@ jobs: | |||
| fail-fast: false # if a particular matrix build fails, don't skip the rest | |||
| matrix: | |||
| arch: ['x64', 'x86', 'aarch64'] | |||
| tag: ['-', '-manylinux-'] # one tag for CPython builds, and another for PyPy | |||
| tag: ['-manylinux1-', '-manylinux2010-', -manylinux2014-] | |||
There was a problem hiding this comment.
minor nitpick here, maybe the leading and trailing hyphen - must not be in the matrix.tag rather it can come a few lines below, where make pull${{ matrix.tag }}${{ matrix.arch }} wheels${{ matrix.tag }}${{ matrix.arch }} should become make pull-${{ matrix.tag }}-${{ matrix.arch }} wheels-${{ matrix.tag }-}${{ matrix.arch }}
This is so that the build name looks neater :)
There was a problem hiding this comment.
Good point. I'll fix that after the release :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that more recent manylinux2010 and 2014 wheels are made in
addition to the older manylinux1 builds.