Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rumble and stop_rumble methods for joysticks and controllers #2741

Merged
merged 3 commits into from Oct 9, 2021
Merged

Add rumble and stop_rumble methods for joysticks and controllers #2741

merged 3 commits into from Oct 9, 2021

Conversation

zoldalma999
Copy link
Contributor

No description provided.

@illume
Copy link
Member

illume commented Oct 3, 2021

Very cool!

Would it be possible to add it to one (or some) of the examples/ ?

@illume illume added the joystick pygame.joystick label Oct 8, 2021
@illume illume added this to the 2.0.2 milestone Oct 8, 2021
@illume
Copy link
Member

illume commented Oct 8, 2021

Weird. Not sure why this is happening. Seems unrelated.

2021-10-08T16:01:44.5055096Z   C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX86\x86\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:prebuilt-x86/SDL2-2.0.16/lib/x86 /LIBPATH:C:\cibw\python\pythonx86.3.7.9\tools\libs /LIBPATH:C:\cibw\python\pythonx86.3.7.9\tools\PCbuild\win32 "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\ATLMFC\lib\x86" "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\lib\x86" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x86" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22000.0\ucrt\x86" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22000.0\um\x86" SDL2.lib /EXPORT:PyInit_transform build\temp.win32-3.7\Release\src_c/transform.obj build\temp.win32-3.7\Release\src_c/rotozoom.obj build\temp.win32-3.7\Release\src_c/scale2x.obj build\temp.win32-3.7\Release\src_c/scale_mmx.obj /OUT:build\lib.win32-3.7\pygame\transform.cp37-win32.pyd /IMPLIB:build\temp.win32-3.7\Release\src_c\transform.cp37-win32.lib
2021-10-08T16:01:44.5321832Z      Creating library build\temp.win32-3.7\Release\src_c\transform.cp37-win32.lib and object build\temp.win32-3.7\Release\src_c\transform.cp37-win32.exp
2021-10-08T16:01:44.5485568Z   transform.obj : error LNK2001: unresolved external symbol _filter_shrink_Y_SSE
2021-10-08T16:01:44.5486516Z   transform.obj : error LNK2001: unresolved external symbol _filter_shrink_X_MMX
2021-10-08T16:01:44.5487488Z   transform.obj : error LNK2001: unresolved external symbol _filter_expand_Y_MMX
2021-10-08T16:01:44.5488247Z   transform.obj : error LNK2001: unresolved external symbol _filter_shrink_X_SSE
2021-10-08T16:01:44.5489000Z   transform.obj : error LNK2001: unresolved external symbol _filter_expand_Y_SSE
2021-10-08T16:01:44.5489738Z   transform.obj : error LNK2001: unresolved external symbol _filter_expand_X_SSE
2021-10-08T16:01:44.5490482Z   transform.obj : error LNK2001: unresolved external symbol _filter_shrink_Y_MMX
2021-10-08T16:01:44.5491217Z   transform.obj : error LNK2001: unresolved external symbol _filter_expand_X_MMX
2021-10-08T16:01:44.5492106Z   build\lib.win32-3.7\pygame\transform.cp37-win32.pyd : fatal error LNK1120: 8 unresolved externals

zoldalma added 3 commits October 8, 2021 21:49
Also renamed docs\ref\controller.rst to docs\ref\sdl2_controller.rst to be inline with video docs.
@zoldalma999
Copy link
Contributor Author

Added a joystick example to examples/. Modified the one from the docs, to support hotplugging (#2078), and will rumble the joystick if you press the 0th button on it.

I am not sure what is causing the CI to fail. Seems like sometimes it builds with MSYS2, sometimes it does not. (None of them work btw). Appveyor does work though, it passes all the tests.

@illume
Copy link
Member

illume commented Oct 9, 2021

Great, thanks for adding the example :)

I am not sure what is causing the CI to fail. Seems like sometimes it builds with MSYS2, sometimes it does not. (None of them work btw). Appveyor does work though, it passes all the tests.

Yeah, definitely unrelated to this PR. msys2 support was recently merged into pygame(#2754). Yeah, as you say... it seems gh workers have different compilers installed depending on the worker you get.

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@illume illume mentioned this pull request Oct 9, 2021
2 tasks
@illume illume merged commit 28abda4 into pygame:main Oct 9, 2021
@zoldalma999 zoldalma999 deleted the haptic-joystick branch October 16, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joystick pygame.joystick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants