Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to type hint (vector2) and docs (draw line) #2717

Merged
merged 1 commit into from Sep 13, 2021
Merged

Update to type hint (vector2) and docs (draw line) #2717

merged 1 commit into from Sep 13, 2021

Conversation

rethanon
Copy link
Contributor

@rethanon rethanon commented Sep 12, 2021 •
edited

This update:

  • removes unrequired keyword "width" for pygame.draw.line in the docs
  • corrects type hint for Vector2 (tuple should contain 2 floats not 3)

@rethanon
Update to type hint (vector2) and docs (draw line)
eae158e 
This update:
- removes unrequired keyword "width" for pygame.draw.line from docs
- corrects type hint for Vector2 (tuple should contain 2 floats not 3)
Starbuck5
Starbuck5 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. 👍

ankith26
ankith26 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good! Thanks for the PR! 👍

@Starbuck5 Starbuck5 merged commit cfb2fa1 into pygame:main Sep 13, 2021
@Starbuck5 Starbuck5 added docs types Type hint checking related tasks labels Sep 13, 2021
@Starbuck5 Starbuck5 added this to the 2.0.2 milestone Sep 13, 2021
@Starbuck5
Copy link
Contributor

Starbuck5 commented Sep 13, 2021 •
edited

And @rethanon, you might want to join the pygame community discord server. Invite link: https://discord.gg/DPtjFPHFtF

It has more of a community feel than the subreddit, and there's a channel for pygame contributing stuff.

@Starbuck5 Starbuck5 added draw pygame.draw math pygame.math labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
docs draw pygame.draw math pygame.math types Type hint checking related tasks
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rethanon @Starbuck5 @ankith26