-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis pricing change, limited build minutes, adjustments needed, github actions? #2300
Comments
Well, thats bad news. Ok, I will start using [skip ci] from now For a heavy CI user like me ;) who commits every little change made, we have to move to github actions quickly :) |
Committing every change is fine, maybe just consider pushing it only when you're at the end of coding a session (or even in some days after). |
Well, now that I’m using git, things will be better, I used to use the github web interface, so even to like change something in another file, I would have to do a separate commit |
I dont know how many people read it but i think we should add a note in Hacking to use [skip ci] if they are just changing the documentation or do it on their own fork if possible (and possibly redirect to a link which explains how to do that). |
Just noticed (in my latest commit), travis has stopped running (even though I forgot to use [skip ci] ) |
Hmm, read through their blog and it does sound bad for pretty much all big open source projects using Travis CI. Big shove to move all their free users over to Github Actions I suppose? I'll have a poke around the other similar projects to pygame and see if they are moving off Travis already (if they were on it) |
Looks like numpy recently made the jump to github actions. See this PR: As did Pillow in this issue and the linked PRs: Looks like a fairly wide consensus to ditch Travis from those projects that were using it. |
What’s the current situation with this issue, should we still be doing [skip ci] on our commits?? |
Seems like they are shutting things down on December 31st now, and it appears there's still no reporting of used minutes. So I guess we are maybe ok until then (it's still unclear though). ps. There was the gh zero day revealed at the start of the month... and they've been deprecating pretty much everything since... so I guess gh actions will be ever more different as the months go on. Ultimately the only proper fix is for them to redo things in an entirely different way.
I still want to do a 2.0.1.dev2 release out with Travis, and then do a 2.0.1 release before starting to move things over. |
travis-ci.org is shutting down by the end of the year, you'll need to migrate to travis-ci.com, which is nominally still "free" for open source, but they give trial credits to begin with and then you need to either pay for a plan or contact support to request free minutes, if the project meets their requirements. https://docs.travis-ci.com/user/migrate/open-source-repository-migration My credits ran out after two weeks and so far I've had no success in getting any OSS credits and can now no longer test my own projects or other projects on Travis CI. You can see how many minutes pygame used for the last month here, 12,607 minutes: |
Thanks for the info @hugovk |
Well if Travis don't count pillow as a valid open source project I doubt they'll count pygame either. These appear to be the deprecated commands with the main security vulnerability in github actions: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Seems to mostly affect workflow actions which run on issues (which anyone can create) so probably won't cause too much bother if we steer away from those two commands and use it for CI. |
We haven't actually asked for credits at Pillow yet, but have moved as much as we can to GHA mainly due to the uncertainty (also get more parallel builds at GHA). We still have some stuff on Travis which can't be migrated to GHA (like unique CPU architectures), so we'll probably have to request soon, and hopefully the project will meet the criteria, unless Tidelift is a problem. Here's the mail Travis sent me when I requested for some of my own projects. Not had any granted yet.
|
I forgot to post this link here: https://blog.travis-ci.com/oss-announcement The TLDR; is they managed to stop the groups using lots of resources on bitcoin mining and such. There's also now a notice about closing down the .org travis "in several weeks". So the situation is a bit different than it was initially. Anyway, I started a local branch refactoring the CI code so it can run where ever in preparation.
Since github actions are free for public repos... we don't need to reduce our used minutes for that reason. Here's a few ideas of the top of my head to reduce minutes:
[Edit: github actions are free for public repos, thanks @hugovk] |
GitHub Actions is free for public repos. |
Now that github actions PR is merged in, the only tasks left should be managing releases from github actions |
So... there's a new note from Travis about how if you use ARM or PPC they offer the service again. Building on ARM would be useful for at least the manylinux builds and also to try to keep our PPC builds working. Using qemu is 5x slower to build ARM images. PPC builds are useful to keep things working for Debian, but also for catching bugs on all platforms. Let's see if it actually does work though... |
After a bit of clicking and fussing, it seems to work. Well, I don't see any 'free oss credits', but they give 10,000 free minutes. So we'll see how that goes. Only the arm64 build is on there. I guess this issue can be closed. We mostly migrated to github actions and appveyor. |
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
TLDR;
Actions to consider:
The text was updated successfully, but these errors were encountered: