Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA concurrency #6210

Merged
merged 10 commits into from Jan 31, 2022
Merged

GHA concurrency #6210

merged 10 commits into from Jan 31, 2022

Conversation

aaronspring
Copy link
Contributor

@aaronspring aaronspring commented Jan 30, 2022 •
edited

  • Closes PRs cancel CI on push #5190
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency

concurrency instead of cancel-duplicate-runs.yaml

@max-sixty
Copy link
Collaborator

Lgtm! Thanks @aaronspring

@max-sixty max-sixty added the plan to merge Final call for comments label Jan 30, 2022
keewis
keewis approved these changes Jan 30, 2022
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is great! Thanks, @aaronspring

@aaronspring aaronspring marked this pull request as ready for review January 30, 2022 23:33
andersy005
andersy005 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @aaronspring! It's my understanding that the concurrency ensures that there are no duplicate jobs for the same ref. I was wondering if we still need the skip-duplicate-jobs as part of the CI?

@aaronspring
Copy link
Contributor Author

In my understanding we can get rid of fkirc/skip-duplicate-actions and cancel-duplicate-runs.yaml

aaronspring
aaronspring commented Jan 31, 2022
View reviewed changes
.github/workflows/ci-additional.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/upstream-dev-ci.yaml Outdated Show resolved Hide resolved
andersy005
andersy005 reviewed Jan 31, 2022
View reviewed changes
.github/workflows/ci.yaml
Comment on lines -14 to -16
if: |
github.repository == 'pydata/xarray'
&& (github.event_name == 'push' || github.event_name == 'pull_request')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronspring, we may want to keep this condition so as to avoid running the CI on forks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t we keep this? @max-sixty @andersy005

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should! @aaronspring, can you open a new PR for that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I merged too early. @aaronspring if you can open a PR then great, otherwise I can as penance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the condition in detect-ci-trigger in #6223

@max-sixty
Copy link
Collaborator

Great — merging, thanks @aaronspring !

@max-sixty max-sixty merged commit b09de81 into pydata:main Jan 31, 2022
@aaronspring aaronspring mentioned this pull request Jan 31, 2022
Merged
@aaronspring aaronspring deleted the patch-2 branch January 31, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

@andersy005 andersy005 andersy005 approved these changes

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRs cancel CI on push
4 participants
@aaronspring @max-sixty @andersy005 @keewis