Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: prepare h5netcdf backend for (coming) change in dimension handling #6200

Merged
merged 2 commits into from Jan 29, 2022

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer
Copy link
Contributor Author

@mathause Although I'm pretty sure that this fixes the upstream-dev run, it would be good to verify. Is it possible to run the upstream-dev with this PR?

@kmuehlbauer kmuehlbauer changed the title MNT: prepare h5netcdf backend for (coming) change in dimension handling WIP: MNT: prepare h5netcdf backend for (coming) change in dimension handling Jan 27, 2022
@kmuehlbauer
Copy link
Contributor Author

I'd also like to add fixes to silence new FutureWarnings emitted by h5netcdf (hence the WIP).

@mathause
Copy link
Collaborator

Great! Thanks for the fix. Yes the string [test-upstream] has to be part of the commit message (if you have nothing new to commit you can do git commit --allow-empty -m "[test-upstream]")

@kmuehlbauer
Copy link
Contributor Author

@dionhaefner

Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344).

Are the chunksizes via h5py and via h5netcdf heuristics correct?

@kmuehlbauer kmuehlbauer changed the title WIP: MNT: prepare h5netcdf backend for (coming) change in dimension handling MNT: prepare h5netcdf backend for (coming) change in dimension handling Jan 27, 2022
@kmuehlbauer
Copy link
Contributor Author

@mathause The fix is applied and works. We have some issues with chunking over at h5netcdf. This will be fixed after sorting this out.

@mathause
Copy link
Collaborator

mathause commented Jan 27, 2022

Looks good. The remaining upstream failure does not seem to be related.

@mathause mathause added plan to merge Final call for comments topic-backends labels Jan 27, 2022
@dionhaefner
Copy link
Contributor

@dionhaefner

Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344).

Are the chunksizes via h5py and via h5netcdf heuristics correct?

Let's take this in h5netcdf/h5netcdf#149.

@mathause mathause merged commit 5470d93 into pydata:main Jan 29, 2022
@mathause
Copy link
Collaborator

Thanks @kmuehlbauer!

@mathause
Copy link
Collaborator

mathause commented Jan 29, 2022

Sorry @kmuehlbauer I was too fast with merging. I have to revert this (#6208) and we can do it again once #6207 is fixed.

@mathause
Copy link
Collaborator

Sorry I was wrong - this was not the cause for the test failure. Let's keep this as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments topic-backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
3 participants