From b7c804a18229288984d82f639b49fbefaa0d9808 Mon Sep 17 00:00:00 2001 From: Pamphile Roy Date: Thu, 5 May 2022 22:14:42 +0200 Subject: [PATCH 1/3] Default activeVersion and activeVersionName --- .../pydata_sphinx_theme/_templates/version-switcher.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html index be76ad719..ba2f2c0da 100644 --- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html +++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html @@ -39,6 +39,9 @@ (function () { $.getJSON("{{ theme_switcher.get('json_url') }}", function(data, textStatus, jqXHR) { const currentFilePath = "{{ pagename }}.html"; + let btn = document.getElementById("version_switcher_button"); + btn.dataset["activeVersionName"] = ""; + btn.dataset["activeVersion"] = ""; // create links to the corresponding page in the other docs versions $.each(data, function(index, entry) { // if no custom name specified (e.g., "latest"), use version string @@ -66,7 +69,6 @@ // version's entry if (entry.version == "{{ theme_switcher.get('version_match') }}") { node.classList.add("active"); - let btn = document.getElementById("version_switcher_button"); btn.innerText = btn.dataset["activeVersionName"] = entry.name; btn.dataset["activeVersion"] = entry.version; } From a469c1cde0033342fee72a9c1b1498330c02e7a7 Mon Sep 17 00:00:00 2001 From: Pamphile Roy Date: Fri, 6 May 2022 10:23:12 +0200 Subject: [PATCH 2/3] Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html Co-authored-by: Chris Holdgraf --- .../theme/pydata_sphinx_theme/_templates/version-switcher.html | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html index ba2f2c0da..49eda65f0 100644 --- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html +++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html @@ -40,6 +40,7 @@ $.getJSON("{{ theme_switcher.get('json_url') }}", function(data, textStatus, jqXHR) { const currentFilePath = "{{ pagename }}.html"; let btn = document.getElementById("version_switcher_button"); + // Set empty strings for active button by default so we can demo in developer mode btn.dataset["activeVersionName"] = ""; btn.dataset["activeVersion"] = ""; // create links to the corresponding page in the other docs versions From 301cd5bc6929ab0ae4f8ce4a38b3d3a466f30c34 Mon Sep 17 00:00:00 2001 From: Pamphile Roy Date: Fri, 6 May 2022 10:26:38 +0200 Subject: [PATCH 3/3] Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html Co-authored-by: Chris Holdgraf --- .../theme/pydata_sphinx_theme/_templates/version-switcher.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html index 49eda65f0..518e6ef12 100644 --- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html +++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html @@ -40,7 +40,7 @@ $.getJSON("{{ theme_switcher.get('json_url') }}", function(data, textStatus, jqXHR) { const currentFilePath = "{{ pagename }}.html"; let btn = document.getElementById("version_switcher_button"); - // Set empty strings for active button by default so we can demo in developer mode + // Set empty strings by default so that these attributes exist and can be used in CSS selectors btn.dataset["activeVersionName"] = ""; btn.dataset["activeVersion"] = ""; // create links to the corresponding page in the other docs versions