Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the space between inline/inline-block elements #983

Closed
12rambau opened this issue Oct 6, 2022 · 1 comment
Closed

Remove the space between inline/inline-block elements #983

12rambau opened this issue Oct 6, 2022 · 1 comment

Comments

@12rambau
Copy link
Collaborator

12rambau commented Oct 6, 2022

In one of my recent PR I realized that there were whitespaces in our primary sidebar (#965 ). The solution was simple, removed the prettifying step and keep inline tags on one single line.

Looking more carefully at our rendered pages I realize that we have trailing whitespaces everywhere.
It seems to be a more general problem as mentioned in this SO post: https://stackoverflow.com/questions/5078239/how-to-remove-the-space-between-inline-inline-block-elements

The "easy" fix is to rely on flexbox instead of inline-block whenever possible. If we do so we'll be able to keep the prettified html output AND avoid the trailing whitespaces.

I think we need to wait for the bootstrap 5 update as many of the display commands are comming from there:

@12rambau
Copy link
Collaborator Author

12rambau commented Jan 9, 2023

we dropped prettify in #1101 that was not really necessary for production

@12rambau 12rambau closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant