Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Run audit on a simplified docs build #892

Merged
merged 2 commits into from Aug 28, 2022

Conversation

choldgraf
Copy link
Collaborator

This modifies our audit CI job so that it runs on a simplified documentation build rather than on our full documentation site.

The reason for this is because we load a lot of extensions, and this often has a significant impact on the audit, even though there's nothing actionable in this theme (for example, see: #891)

This should make our audit results more reliable, simpler, faster, and less variable since it's only tied to this theme and not the extensions we load with it.

@choldgraf
Copy link
Collaborator Author

choldgraf commented Aug 27, 2022

As a nice side-benefit, our CI is now passing!

(except for the prerelease test which now fails, I think because of some deprecated pandas thing? Maybe @jorisvandenbossche can advise? I think this might be a bug in pandas docstring)

/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/site-packages/pandas/core/frame.py:docstring of pandas.core.frame.DataFrame.groupby:42: WARNING: undefined label: 'groupby.transform'

@choldgraf choldgraf merged commit 3440045 into pydata:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Our audit CI job is failing on the performance job
2 participants