New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression with v0.10rc2 sidebar links for scipy and arrow docs #855
Comments
Comparing 0.9.0 with 0.10.0rc2 and testing this with the Arrow docs, I also see some slowdown: the total build went from around 9 minutes to around 13.5min (both using the same sphinx version (still 4.2 in my test env), only the theme version differed). I profiled both cases for the writing files phase (as that phase visually (from the live progress output) seemed to show a slowdown). From a quick look at those profiles, it seems that pydata-sphinx-theme/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html Lines 6 to 8 in 06a35ad
should actually ensure it's only called once. |
I wonder if the problem is because we now generate the navbar in two places. First in the navbar, and a second time in the sidebar (so that the navbar shows in the sidebar at the top on mobile). Maybe it re-calculates the links each time? Either way, this is almost certainly because of how the navigation links are generated, that's by far the most time we spend. I think that's where I'd look to improve the performance. |
I think that this issue is potentially a simpler way to resolve this problem: |
I looks like the PR I linked above doesn't really speed things up (at least for the SciPy docs). I am not sure what to do here, I don't have time to debug this issue, can anybody try to find a fix for this? Otherwise we are just going to be stuck in Release Candidate purgatory for a while I guess. |
I will try to have a look tomorrow or friday. after that I'm at a project-specific hackathon the following week, so may need to pass the baton. |
copied over from #878 I was not able to reproduce the slow-down reported in this issue. It seems like
This is what resulted: This is confusing to me, because it's significantly faster on So are we really sure that there is a significant slow-down? |
Also some findings from #878. On SciPy the slowdown comes from the use of |
While testing the RC for 0.10, I noticed that the Sphinx build time significantly increased.
Here is an example of CI timing out now with RC2 scipy/scipy#16660
On
main
, we use 0.9 and there is no apparent issue.The text was updated successfully, but these errors were encountered: