Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our search button show in the header on mobile #824

Closed
choldgraf opened this issue Jul 18, 2022 · 4 comments · Fixed by #832
Closed

Make our search button show in the header on mobile #824

choldgraf opened this issue Jul 18, 2022 · 4 comments · Fixed by #832

Comments

@choldgraf
Copy link
Collaborator

Context

Currently, our search button lives in navbar_end and behaves similarly to all of the other buttons. However, it is common for people to want to search for things moreso than clicking icon links etc, and so it is a bit annoying when you have to click 2 times in order to do that.

A pattern I've seen in a few places is to put the search button as a "sibling" of the "collapse button" when you're on mobile. That way people can click to search with one click from the mobile landing page. For example, from the Wowchemy docs:

image

Material for mkdocs:

image

Proposal

I propose that we special-case the search button so that it shows up just next to the "collapse header" button by default on mobile.

@drammock
Copy link
Collaborator

Agreed.

@12rambau
Copy link
Collaborator

LGTM

@12rambau
Copy link
Collaborator

it @choldgraf, isn't it now solved in main with your new interface for the header navbbar ?

Capture d’écran 2022-08-28 à 08 50 13

@choldgraf
Copy link
Collaborator Author

Yes! Good catch. I believe this was closed by #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants