Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistune-3.0.0a1 breaks things #805

Closed
jarrodmillman opened this issue Jul 12, 2022 · 5 comments
Closed

mistune-3.0.0a1 breaks things #805

jarrodmillman opened this issue Jul 12, 2022 · 5 comments

Comments

@jarrodmillman
Copy link
Collaborator

jarrodmillman commented Jul 12, 2022

With mistune-2.0.3 and nbconvert-7.0.0rc2, things work. With mistune-3.0.0a1 and nbconvert-7.0.0rc2 we get:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/nbconvert/filters/markdown_mistune.py", line 49, in MathBlockParser
    RULE_NAMES = ("multiline_math",) + BlockParser.RULE_NAMES
AttributeError: type object 'BlockParser' has no attribute 'RULE_NAMES'

This depends on one of these two upstream issues:

@choldgraf
Copy link
Collaborator

Good catch - I added the two upstream issues that I think need to be resolved for this one to be fixed.

Do you think that this issue should block the next release (via being attached to this milestone)? I think that might be a while before this is fixed

@choldgraf choldgraf modified the milestones: 0.10, 0.11 Jul 15, 2022
@choldgraf
Copy link
Collaborator

I'm going to bump this one to 0.11, since I think we want to make a release before this issue will likely be resolved.

@TiagodePAlves
Copy link

An update for Mistune v3 is already prepared in jupyter/nbconvert#1820, just waiting for a final release.

@jarrodmillman jarrodmillman modified the milestones: 0.11, 0.12 Sep 20, 2022
@12rambau 12rambau modified the milestones: 0.12, 0.13 Nov 17, 2022
@choldgraf choldgraf removed this from the 0.13 milestone Jan 9, 2023
@12rambau
Copy link
Collaborator

12rambau commented Jun 1, 2023

we are not directly impoting mistune ourselves, is'nt something that should be handled from nbconvert ?

@jarrodmillman
Copy link
Collaborator Author

https://pypi.org/project/mistune/3.0.0/ is out. Now we just need to wait for nbconvert to update:

I will close this and comment on the nbconvert issue and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants