Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table captions #695

Merged
merged 1 commit into from Jun 4, 2022
Merged

Improve table captions #695

merged 1 commit into from Jun 4, 2022

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Jun 4, 2022

Fix #588

replace table captions on top of the table. I also took the liberty of centering them.
https://pydata-sphinx-theme--695.org.readthedocs.build/en/695/demo/kitchen-sink/lists-and-tables.html#list-tables

@12rambau 12rambau marked this pull request as ready for review June 4, 2022 10:57
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement IMO !

@jarrodmillman jarrodmillman added this to the 0.9 milestone Jun 4, 2022
@choldgraf choldgraf changed the title improve table captions Improve table captions Jun 4, 2022
@choldgraf choldgraf merged commit 46de2f6 into pydata:main Jun 4, 2022
@12rambau 12rambau deleted the table branch June 4, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caption location below table can be confusing
3 participants