Prevent theme mamangement to raise error when the mode is fixed #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Jun 4, 2022
jarrodmillman
approved these changes
Jun 4, 2022
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
choldgraf
reviewed
Jun 4, 2022
choldgraf
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #684
I silence the javascript related to the theme management if the theme switcher is not in the DOM. It removes the errors from the console.
I completed the documentation with explaination on how to fix the mode to a specific value.
The code was already there but there was a typo preventing the display in the doc (note for self Pygments warning lead to no display). https://pydata-sphinx-theme--692.org.readthedocs.build/en/692/user_guide/configuring.html#configure-default-theme
To answer the issue more specifically, the default behaviour remain "auto" with the theme swithcer in the navbar but I takes 2 lines in conf.py to silence it (and it's now documented).