Use dataclasses instead of extra_classes #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupui
approved these changes
Feb 24, 2022
damianavila
reviewed
Feb 25, 2022
damianavila
reviewed
Feb 25, 2022
damianavila
reviewed
Feb 25, 2022
damianavila
reviewed
Feb 25, 2022
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html
Show resolved
Hide resolved
damianavila
reviewed
Feb 25, 2022
choldgraf
force-pushed
the
enh-version-autolabel
branch
from
434cd25
to
d597406
Compare
|
OK - addressed each of @damianavila's suggestions, and also rebased on |
|
Master is currently broken given #574 (comment) I have a fix in place in an upcoming PR: #599. Let's merge that one first and rebase this one so we can effectively compare. |
|
I've merged #599 and updated this branch as well, so that we can compare the changes in code + functionality more directly. Would love feedback on whether this PR is the right direction to go, and anything we'd need to change here. |
damianavila
reviewed
Mar 5, 2022
|
Updated the example @damianavila - also updated the CSS per your suggestions |
|
And I merged it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our version switcher to use
dataclassentries for all dropdown links and the button itself, rather than having users manually add classes to the JSON entries.closes #596