ENH: Add left sidebar end section to bottom #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
ENH-sidebar-end
branch
from
d27b180
to
01f7186
Compare
choldgraf
force-pushed
the
ENH-sidebar-end
branch
from
01f7186
to
09dea71
Compare
damianavila
reviewed
Jan 10, 2022
damianavila
reviewed
Jan 10, 2022
It seems the ethical ads are lately also not working on the actual readthedocs site? -> https://pydata-sphinx-theme.readthedocs.io/en/latest/index.html |
|
Generally +1 on the change, though! |
|
@jorisvandenbossche the ads work on my computer - here's a screenshot for the current website
maybe you have an ad blocker that is blocking it? |
I can confirm I can see it even with an ad blocker 馃槈 . |
You need to stop working at night!! 馃槾 |
choldgraf
commented
Jan 11, 2022
|
It's indeed my ad blocker, should have thought of that! :) |
|
thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra div to the bottom (called "end" in our classes etc) of the left sidebar. This means that by default, the ReadTheDocs "ethical ads" div will snap to the bottom of the page rather than coming just after the left navigation content.
It also makes this section extensible in the way others on the page are, via the
left_sidebar_endkey.This is preferable for pages that have only a small amount of left sidebar content, because it'll mean that the ethical ads thing isn't in the middle of the page.
It's a bit hard to demo because ReadTheDocs doesn't show the ethical ads on PR previews, but if I manually increase the height of that div and show where it is, you get the idea:
(sorry for the red tint, that's not included in the PR 馃槄