Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in spacing (margin-bottom) in lists #223

Closed
jorisvandenbossche opened this issue Jul 6, 2020 · 3 comments
Closed

Change in spacing (margin-bottom) in lists #223

jorisvandenbossche opened this issue Jul 6, 2020 · 3 comments
Labels
kind: bug Something isn't working

Comments

@jorisvandenbossche
Copy link
Member

Compare our own home page https://pydata-sphinx-theme.readthedocs.io/en/v0.3.1/ vs https://pydata-sphinx-theme.readthedocs.io/en/v0.3.0/

The list of projects looks like this with 0.3.0

image

and like this on master / with 0.3.1:

image

cc @choldgraf #207 seems to be the only PR in that window that touched css, but not directly sure how that change would have caused this (as the change should be limited to admonitions). Maybe another external change (eg in sphinx) caused this.

@choldgraf
Copy link
Collaborator

ah yeah good catch - I'm not sure if/how the admonitions CSS would affect this either 🤷‍♂️

@choldgraf choldgraf added the kind: bug Something isn't working label Jul 6, 2020
@jorisvandenbossche
Copy link
Member Author

This might be a sphinx thing: sphinx-doc/sphinx#7838

@jorisvandenbossche
Copy link
Member Author

And indeed, on the latest master build (from the just merged PR), using sphinx 3.1.2 I suppose, this seems OK again: https://pydata-sphinx-theme.readthedocs.io/en/latest/ (fixed by sphinx-doc/sphinx#7852 I suppose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants